Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483498 --- Comment #9 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-03-04 12:36:44 EDT --- For 0.1-2: * Name - As you define %_appname macro, you can use this macro also on Name. ! Note For some reason (mostly due to unpredictable behavior on nested macros), now Fedora packaging guideline suggests to use %global instead of %define. c.f (although this says "Drafts", this is already accepted) https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define * License -------------------------------------------------- The images in this directory were created by MERCIER Jonathan <bioinfornatics@xxxxxxxxx>. They are distributed under the terms of the GNU GPL. -------------------------------------------------- - In this case the license tag should be "GPL+" * Timestamps - Please use "-p" option when using "cp" or "install" command to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps ("cp -a" keeps timestamps) * Directory ownership issue - Now (on rawhide) the directory %_datadir/backgrounds is owned by filesystem, so please don't make this package own this package. - build.log says ------------------------------------------------------ 71 warning: File listed twice: /usr/share/backgrounds/earth-and-moon ------------------------------------------------------ Note that the following %files entry ------------------------------------------------------ %files %{_datadir}/backgrounds/earth-and-moon ------------------------------------------------------ contains this directory itself and all files/directories/etc under this directory (i.e. %dir %{_datadir}/backgrounds/earth-and-moon is not needed) - On the other hand currently it is uncertain which package should own the directory %{_datadir}/gnome-background-properties/. So for now please make this package own this directory. * %changelog - I suggest to put one line between each %changelog entry like ------------------------------------------------------ * Wed Feb 18 2009 Jonathan MERCIER <bioinfornatics at gmail.com> - 0.1-2 - change package name to earth-and-moon-background * Sat Oct 25 2008 Jonathan MERCIER <bioinfornatics at gmail.com> - 0.1-1 - Initial release ------------------------------------------------------ This is useful when using Fedora CVS system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review