Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488105 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-03-03 19:57:24 EDT --- This is a very simple ruby package. I went through it and didn't find any problems. But I have a few questions and two little suggestions: ? The other rubygem packages have BR: ruby(rubygems). This one has BR: rubygems. Why is there a difference? Does it matter? Also BR: ruby(abi) = %{rubyabi} will be pulled up by BR: rubygems. Do we really need to specify it specifically? I know the guidelines tell us to do so. But I don't know why. ! The ruby guidelines tell us to use %global instead of %define. While it doesn't matter much in this case, it would be good to obey the guidelines. ! It would look nicer and consistent if you make the description span evenly and use the full 80 columns. Otherwise, the package is good to go: ------------------------------------------------------- This package (rubygem-htmlentities) is APPROVED by oget ------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review