Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478852 --- Comment #4 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-03 14:49:12 EDT --- (In reply to comment #3) > > %defattr(-,root,root,-) won't work? Why? > > Probably works. I have never used them. I started using RPMs when original > packages were made only by RedHat and there were many user pages with packages. > I was safer in my opinion to force mentioned rights (especially for suided > files). > Are there situations where (-,root,root,-) is better? Automatic builds uses > (0644,root,root,0755) anyway. Well, by guidelines you should use (-,root,root,-) "unless you have a very good reason to deviate from that": https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions > > * desktop-file-install warns about the Icon= entry > > Probably I have too old desktop-file-install (Fedora 8), but I didn't see any > warning. Is it about .png extension? > If yes I would have to patch original file or create a new one. Is it worth to > do that? Yes, short name should be without extension. Add "CC-BY-SA" to License tag as package includes some of tango icons. License status of fonts and sounds must be clarified. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review