Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486961 --- Comment #3 from Ondrej Vasik <ovasik@xxxxxxxxxx> 2009-03-03 10:24:06 EDT --- Additionally groupdel in postun would mean deleting that group even on update (as postun is run after post). Other checks: + package builds in mock (development i386). + rpmlint is silent for SRPM + rpmlint is not silent for RPM. - mostly could be ignored: - .so is in lib<package> - servicelog.db file strange permissions are recommended in usptream installation procedure, so I guess required - dangerous groupdel in postun mentioned earlier + source files match upstream. e3280d47a16a29beef586d5b6068a562 libservicelog-1.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. - .pc file present (in devel subpackage). - I guess it is necessary for that package - Requires: pkgconfig is missing for devel subpackage + no .la files. + no translations are available. - Does NOT owns the directories it creates. /var/lib/servicelog has to be owned + no duplicates in %files. + file permissions are appropriate. + Not a GUI app. Summary of things to fix: 1) groupdel in post (consider complete removal) 2) var/lib/servicelog has to be owned 3) Requires: pkgconfig is missing for devel subpackage -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review