Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478852 --- Comment #1 from Alexey Torkhov <atorkhov@xxxxxxxxx> 2009-03-03 03:20:21 EDT --- - Avoid use of %makeinstall macros if "make install DESTDIR=%{buildroot}" working: https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used - Add desktop-file-utils to BuildRequires. - Remove "--vendor fedora" from desktop-file-install call as per guidelines. - Running update-desktop-database in %post and %postun is not needed as desktop entry doesn't has 'MimeType' key: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review