Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: quodlibet - A music management program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202496 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-17 02:01 EST ------- You missed one tab, in Source58. You should package COPYING, HACKING, NEWS and README as %doc. Also, what's the upstream for google.py? From the looks of things, it's you, which would be OK. It seems to me that there must be a simpler way to copy 50 sources into place. The README file says there are unit tests included, but I don't see them in the package. I built this for i386 and installed it on my home machine; it seems to run OK but I saw this odd bit on startup: Introspect error: The name org.gajim.dbus was not provided by any .service files I found errors with four plugins: ImportError: No module named musicbrainz ImportError: No module named CDDB ImportError: No module named lastfm ImportError: No module named path I guess the first three are optional requirements, which should be OK. The last one is odd; here's the full backtrace: Traceback (most recent call last): File "/usr/share/quodlibet/plugins/songsmenu/shell.2.py", line 11, in ? import os File "/usr/lib/python2.4/os.py", line 133, in ? from os.path import (curdir, pardir, sep, pathsep, defpath, extsep, altsep, ImportError: No module named path In addition, I chose View->File System and got this backtrace: Traceback (most recent call last): File "/usr/share/quodlibet/qltk/quodlibet.py", line 518, in select_browser self.browser = Browser(library, player) File "/usr/share/quodlibet/browsers/filesystem.py", line 67, in __init__ dt = DirectoryTree(initial=const.HOME, folders=folders) File "/usr/share/quodlibet/qltk/filesel.py", line 68, in __init__ folders = filter(is_folder, folders) UnboundLocalError: local variable 'is_folder' referenced before assignment I exited the program which left the default view that way and now neither quodlibet nor exfalso will start. These are probably issues for upstream, but I just wanted to make sure that something wasn't missing from the package. For some reason I don't get any desktop menu entry, even though the desktop file looks OK to me. (I use KDE.) Review: * All 9000 source files match upstream: 195c39433b4e2a5bf930af7570b61f3e quodlibet-0.23.tar.gz 0b7d2ff31c4c113b52b74e1b8c867843 albumart.py 2385a15ea0f8c4ccbcf347eb9e5ef174 _amazon.py b5f85eb37b75acba938d082913d31b32 animosd.py 17421585b258ac44a0c04a50f06b25da ape2id3.py 680c7f7df3ac0cd949daa153c419e451 automask.py f3d86669ab18d4c25075212943cd74e1 autorating.py 9a984fb37453ff86ac861b01b31f6594 bookmarks.py 3865f4f3ece8d667c20fe3b8d34418dd brainz.py ab800ac4b48a0a228f1504914f198b5a browsefolders.py ae0be895b7441c9d38b0d8725f53f46c cddb.py 73c4409dfbdc8a9d8b7cd1a04f86ac23 clock.py c898ef2d38ad04b64137f0b6a8845852 fixlatin1tags.py 0fb2b513d89026c809b77c423c5080f8 gajim_status.py ae32b874d01fb16bed24626602ed2a98 html.py 4b71dfdbed6d5e8248028f62a3290888 iconv.py cd8f349983822b0429ef36d51c506992 ifp.py 4fd524e514cb0da6714628c7c1078242 importexport.py 57c82a80c4f30f6ac9b87801e7c80728 iradiolog.py d73546846d3280d0d3b2548a97bd8991 jep118.py 692f212693a86de9858e4979d6cec1b6 k3b.py 437ab5e65b7788641880b1ff7f4ae9f4 kakasi.py 57cf89358975fc75267bbff6d629749f lastfmsubmit.py c235836bb4b3f0480f674b6d21996407 nautilus.py 2a140f01260cb7dc5fc89f95fe11b4e0 notify.py d9868612bc1a13536f37d321bd4748d2 qlscrobbler.py 77dd97961b563ce6a0e0e596d98c39fe randomalbum.py f179c4db522561eed1629854b8de3a4d replaygain.py cb8f5b018503b2f0ad44fc10fc0bd3be reset.py dbd51ebd76b5a8e0a23558480c79da7b resub.py e5fc6a506f63de6f9661d2ded274d70d splitting.py 09c6da4082b6aa33d998991be7c508a8 _subprocobj.py 18ba6a789e95d5d202d911d826d94747 titlecase.py 12a36f1cc82b14cb25ba54b3d84503c8 trayicon.py 87065bf6d3b2084ca1a1c1f06f2b3f6c wikipedia.py 705e734f3d755a1e05854bc68ed90f6a write_cover.py Source58, pulled manually according to the comments, also matches: 5a9d7e599fab9be828a6244ee12e3542 shell.2.py?format=raw No upstream for google.py * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. X license is open source-compatible. License text upstream but not included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * debuginfo package looks complete. X rpmlint is silent (just one tab) * final provides and requires are sane: _mmkeys.so()(64bit) quodlibet = 0.23-3.fc6 = /usr/bin/env gnome-python2-libegg gstreamer-python >= 0.10 libatk-1.0.so.0()(64bit) libcairo.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) pygtk2 >= 2.8 python >= 2.4 python-mutagen >= 1.5 vorbisgain ? %check is not present; no test suite upstream. Manual testing reveals a few problems; see above. * shared libraries are present, but they aren't in the ld search path. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * desktop file looks correct and is installed properly. (Note that I don't get a desktop menu entry, but I don't see anything wrong with the desktop file.) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review