Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487587 Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |suravee.suthikulpanit@xxxxx | |om --- Comment #1 from Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx> 2009-03-02 13:23:38 EDT --- This is the unofficial review - Could not locate the upstream Source0 (debuginfofs-0.1.tar.bz2) to compare the checksum. (The snapshot from GIT summary is a tar.gz file, while the included package has tar.bz2) - rpmlint outputs the following: rpmlint -iv /root/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm debuginfofs-server.noarch: I: checking debuginfofs-server.noarch: W: conffile-without-noreplace-flag /etc/httpd/conf.d/dav-debuginfo.conf A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here - Package does not include license text. SUGGESTIONS: - In "%sfiles server", use "%{_sbindir}/debuginfofs-mirror" instead of "/usr/sbin/debuginfofs-mirror". - In "/etc/rc.d/init.d/debuginfofs": * The chkconfig header has the startPriority + stopPriority > 100. * The script does not have all the required actions. (Missing reload, force-reload, usage) Please see http://fedoraproject.org/wiki/Packaging/SysVInitScript. OKAYS: - rpmlint is quiet for debuginfofs package - package built, and installed cleanly - BuildRoot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - file permission (-,root,root,-) - rpm -qp --provides ~/rpmbuild/RPMS/noarch/debuginfofs-0.1-0.fc10.noarch.rpm config(debuginfofs) = 0.1-0.fc10 debuginfofs = 0.1-0.fc10 - rpm -qp --provides ~/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm config(debuginfofs-server) = 0.1-0.fc10 debuginfofs-server = 0.1-0.fc10 - rpm -qp --requires ~/rpmbuild/RPMS/noarch/debuginfofs-0.1-0.fc10.noarch.rpm /bin/bash /bin/sh /bin/sh /bin/sh chkconfig chkconfig config(debuginfofs) = 0.1-0.fc10 initscripts initscripts rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 wdfs - rpm -qp --requires ~/rpmbuild/RPMS/noarch/debuginfofs-server-0.1-0.fc10.noarch.rpm /usr/bin/python config(debuginfofs-server) = 0.1-0.fc10 cpio httpd rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review