Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487421 --- Comment #4 from Michael DeHaan <mdehaan@xxxxxxxxxx> 2009-03-02 10:58:50 EDT --- The following items were listed as "musts" and all pass: + rpmlint ok + package name ok + spec name ok + guidelines ok + license: ok, matched + license in %doc, ok + specfile is English + specfile is legible (TARBALL MUST MATCH UPSTREAM) + compiles/builds ok on my i686 install, satisfying the "at least one primary arch rule" + no ExcludeArch required + no BuildRequires required, basic C library + no use of locales required, basic C library + calls ldconfig in %post and %postun as required + not relocatable + owns all directories since it creates zero of them + no duplicate files + defattr is correct + contains proper clean section + macro usage ok + package is code, not content, ok + no large docs, ok + docs do not affect runtime, ok + devel package created, ok + static package created, ok + pkgconfig N/A, ok + libraries ok + devel requires base as N-V-R, ok + no libtool archives, ok + no GUI apps, ok + no reownership, ok + cleans buildroot at install, ok + filenames are valid UTF-8, ok All MUST items has passed, now reviewing SHOULD items. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review