Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487639 --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-02-28 13:36:16 EDT --- PRE-review for 0.2.6-2 (yes, PRE-review...) * About patch - Would you explain what the soname "libzzub.so.0.3" "liblunarstd.so.0" come from? (anyway the soname "libzzub.so.0.3 is wrong, it should be "libzzub.so.0" or so) - Also, non-patched src/plugins/lunar/SConscript seems to be saying that liblunarstd.so is a plugin module, not a system-wide library. Are you sure that this file should really be system-wide library? * License tag - License tag is inherited to all subpackages unless explicitly specified (try $ rpm -qi armstrong-devel or so. I think this should just be "GPLv2+") * internal libraries -------------------------------------------------------------------------- # Remove the binded libraries. We'll use the internal ones -------------------------------------------------------------------------- - You mean "external ones"? * Document directories -------------------------------------------------------------------------- %doc installed_docs/* %{_defaultdocdir}/zzub -------------------------------------------------------------------------- - With this armstrong will own two directories for documents, %{_defaultdocdir}/{zzub,%{name}-%{version}}. I think this is confusing and these directories should be unified. - Also, anyway as this spec file has: -------------------------------------------------------------------------- # We want to install docs to the proper location: mkdir -p installed_docs mv $RPM_BUILD_ROOT%{_docdir}/zzub/* installed_docs/ -------------------------------------------------------------------------- Currently %_defaultdocdir/zzub is just empty. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review