Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480102 --- Comment #5 from Michel Alexandre Salim <michel.sylvan@xxxxxxxxx> 2009-02-27 10:11:48 EDT --- (In reply to comment #4) > Most of the changes are fine. Would be a good idea to turn on the test suite, > between %build and %install: > > %check > CLASSPATH=/usr/share/java/junit4.jar ant run_tests > Of course, that should have been BuildRequires: junit %check CLASSPATH=/usr/share/java/junit.jar ant run_tests It takes forever to run, though, so perhaps surround it in an %if? %if %{?_with_tests:1}%{!?_with_tests:0} %check ... %endif (and put a one-line comment at the top describing the --with tests option) But that's secondary -- apart from the desktop file naming, this is good to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review