Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libconfuse - A configuration file parser library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820 dan@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From dan@xxxxxxxx 2006-08-16 15:51 EST ------- Review: - no rpmlint output on any package - package name OK - spec file name OK, is in English and is legible - package meets the Packaging Guidelines - license OK (LGPL) and is included - source matches upstream 4bc9b73d77ebd571ac834619ce0b3582 confuse-2.5.tar.gz 4bc9b73d77ebd571ac834619ce0b3582 confuse-2.5.tar.gz.1 - compiles and builds at least on i386 (FC4 and devel) - BuildRequires are correct - localized files are handled with %find_lang - has shared lib with appropriate ldconfig calls - does not create any directory - no duplicates files, permissions are set properly, uses %defattr - has %clean section - consistent use of macros - contains code - no large docs, %doc is not required during runtime - devel subpackage required and present, contains pkgconfig file - no .la libtool archives - not a GUI application - it works APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review