Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486044 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-02-26 11:37:38 EDT --- > Two of the tests are badly written and fail. There is no problem with the > functionality of the package. This should be reported upstream REVIEW: + rpmlint is ok php-pear-Config.src: I: checking php-pear-Config.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name + spec file name + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + no license file in sources is provided + sources match the upstream sources ec85ece7ddd28a0a139c0699481c0116 Config-1.10.11.tgz + Source URL ok + build on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + small documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (fedora-rawhide-x86_64) + test suite : see previous comment + scriptlets ok + Final Requires ok /bin/sh /usr/bin/pear php-pear(PEAR) php-pear(XML_Parser) php-pear(XML_Util) + Final Provides ok php-pear(Config) = 1.10.11 php-pear-Config = 1.10.11-2.fc8 php-pear(PEAR) should be removed from Requires as already required by php-pear(XML_Parser) and php-pear(XML_Util) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review