Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=224245 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #23 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-02-24 18:26:45 EDT --- I don't think your response has been at all slow, especially compared with the speed of most merge reviews. (I have some where I haven't been able to get a response for 18 months.) I'll go ahead and do a full review now. Honestly the only thing I can add is that that you can drop the versioned dependencies on php and tmpwatch, since the required versions have been present in every release as far back as I can see (FC1, at least). Not really a big deal. * source files match upstream. sha256sum: 8fa5b82bb2e4448da80d2ccc42ec9874df8674691358736da6c7c3f7bbbae639 all_locales-1.4.13-20071220.tar.bz2 b14d3ef3735f8c7b49b091533c567048b3a06eb633eccbfeddd7cd8fdd2ffe25 squirrelmail-1.4.17.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints * final provides and requires are sane: config(squirrelmail) = 1.4.17-2.fc11 squirrelmail = 1.4.17-2.fc11 = /bin/sh /usr/bin/env /usr/sbin/sendmail aspell config(squirrelmail) = 1.4.17-2.fc11 httpd perl perl(Cwd) ? php >= 4.0.4 php-mbstring ? tmpwatch >= 2.8 * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, and closed. Thanks for your time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review