[Bug 483434] Review Request: argtable2 - A library for parsing GNU style command line arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483434





--- Comment #5 from Christian Krause <chkr@xxxxxxxxxxx>  2009-02-24 15:04:47 EDT ---
Hello Jess,

good:
- all mentioned issues solved
- content of the binary packages is now ok

very minor issue - just for completeness:
- omit the macro in the changelog of the spec file, otherwise rpmlint will
complain:
SPECS/argtable2.spec:66: W: macro-in-%changelog _defaultdocdir

- you've added the spec file to the sources, so the sources in the provided
src.rpm are slightly different from the ones on sf.net


Besides these two little minor issues I think the package looks very good.
Since I'm not an "offical" reviewer I could only help you up to this point and
so somebody with that status has to do the final formal review to give you the
approval for the new package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]