Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484563 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-02-23 12:58:39 EDT --- REVIEW: + rpmlint is ok php-ezc-ConsoleTools.src: I: checking php-ezc-ConsoleTools.noarch: I: checking 2 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines (new update) + License ok : BSD + License is upstream + spec in english and legible + license file in sources is provided + sources match the upstream sources b680b22c79f7e665e604354f6bdb3383 ConsoleTools-1.5.tgz + Source URL ok + build on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 - not tested with mock + no test suite + scriptlets ok - Final Requires KO - Final Provides KO MUST fixe (ezc => components.ez.no) : Requires: php-pear(%{channel}/Base) >= 1.6 Provides: php-pear(%{channel}/%{pear_name}) = %{version} To be removed (already required by Base) Requires: php-pear(PEAR) Requires: php-channel(%{channel}) Requires php-common >= 5.2.1 could be kept as it could be different (between packages) in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review