Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486009 --- Comment #6 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-02-23 11:54:21 EDT --- REVIEW: + rpmlint is ok php-pear-Crypt-Blowfish.src: I: checking php-pear-Crypt-Blowfish.noarch: I: checking php-pear-Crypt-Blowfish.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name + spec file name + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources + sources match the upstream sources 09f0e38a4d524ba4102db5d11b07ffe9 Crypt_Blowfish-1.1.0RC2.tgz + Source URL ok + build / run on F10.x86_64 + BuildRequires (php-pear >= 1:1.4.9-1.2) ok + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in mock (fedora-rawhide-x86_64) + test suite ok (2 PASSED TESTS) + scriptlets ok - Final Requires ok, but see previous comments - Final Provides ko, see previous comments php-pear(foo) = 1.1.0 Just fix the previous comment and I will approve this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review