Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485596 --- Comment #3 from Joseph Smidt <josephsmidt@xxxxxxxxx> 2009-02-22 16:32:02 EDT --- Thanks a lot for your comments. (In reply to comment #2) > Some comments about the spec : > 1) Source0 should be an URL (the appropriate one : > http://www.phoronix-test-suite.com/releases/phoronix-test-suite-1.6.0.tar.gz) Done > 2) The PTS is a PHP program so the package doesn't need a particular > architecture. Add "BuildArch: noarch" after "BuildRoot:" Done > 3) Where do you find all this dependencies ? The PTS site just give me "php-gd" > and "php-cli" ; for the rest, I suppose that the "External Dependencies" > feature work with yum. It is true you only need "php-gd" and "php-cli" to run the program. However, when you run the program it executes the script found in the source phoronix-test-suite/pts/distro-scripts/install-fedora-packages.sh which scans phoronix-test-suite/pts/distro-xml/fedora-packages.xml and asks the user to download all those packages. (So I got all the dependencies from the fedora-packages.xml file) I thought it would be better to have Fedora install those packages for the user up front then have PTS do it. What would you prefer? > 4) Add a %build section even if it's empty Done Here are the new files: Spec URL: http://jsmidt.fedorapeople.org/phoronix-test-suite.spec SRPM URL: http://jsmidt.fedorapeople.org/phoronix-test-suite-1.6.0-1.fc10.src.rpm whit the new rpmlint: rpmlint phoronix-test-suite-1.6.0-1.fc10.noarch.rpm phoronix-test-suite.noarch: E: non-executable-script /usr/share/phoronix-test-suite/pts-core/modules/dummy_script_module.sh 0644 phoronix-test-suite.noarch: E: devel-dependency SDL-devel phoronix-test-suite.noarch: E: explicit-lib-dependency compat-libstdc++-33 phoronix-test-suite.noarch: E: explicit-lib-dependency libXv-devel phoronix-test-suite.noarch: E: explicit-lib-dependency libXvMC-devel phoronix-test-suite.noarch: E: explicit-lib-dependency libaio-devel phoronix-test-suite.noarch: E: explicit-lib-dependency libjpeg-devel phoronix-test-suite.noarch: E: explicit-lib-dependency libpng-devel 1 packages and 0 specfiles checked; 8 errors, 0 warnings. Thanks again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review