Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486009 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2009-02-22 02:17:20 EDT --- First notes : - It requires PEAR >= 1.7.2 (according to upstream and to xml) : this will block this package for EPEL. - rpmlint warning : W: summary-not-capitalized quick two-way blowfish encryption - %file must be fixed %files %defattr(-,root,root,-) %{pear_xmldir}/%{pear_name}.xml %{pear_testdir}/%{pear_name} %{pear_phpdir}/Crypt - I would prefer using %{name}.xml rather than %{pear_name}.xml (see recently approved PHP Guidelines, this is usefull to avoid conflict between package from various channel) - a comment about running the tests (which must be done as root after install) will be usefull : => pear run-tests -p Crypt_Blowfish -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review