Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476404 --- Comment #24 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-02-20 13:49:54 EDT --- For 2.73-4: * Description ------------------------------------------------------------ Free for commercial use, including Playstation 3, open source under the ZLib License. ------------------------------------------------------------ - I think this part can be deleted (actually all packages in Fedora must generally be free, and the correct license information can be received from License tag) * Directory ownership issue - Still some directories are not correctly owned (%{_includedir}/BulletCollision/, %{_includedir}/BulletDynamics/) ! Note Writing %files list verbosely like this way is usually error-prone. Instead I recommend to use the format like: ------------------------------------------------------------ %files %defattr(-,root,root,-) %doc ... .... %{_includedir}/*.h %{_includedir}/BulletCollision/ %{_includedir}/LinearMath/ ...... ------------------------------------------------------------ Here the %files entry ------------------------------------------------------------ %files foo/ ------------------------------------------------------------ (where foo/ is a directory) contains the directory foo/ itself and all files/directories/etc under foo/, so writing %files list in this way is much safer. ref: https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory * Missing ldconfig symlinks (In reply to comment #23) > Does that mean I should dig around CMake and make sure files like > libBullet*.so.2 are also generated ? - The following is sufficient. ------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT pushd $RPM_BUILD_ROOT%{_libdir} for f in lib*.so.*.* do ln -sf $f ${f%\.*} done popd ------------------------------------------------------------- * Misc rpmlint issue ------------------------------------------------------------- bullet.i586: W: file-not-utf8 /usr/share/doc/bullet-2.73/ChangeLog bullet.src: W: strange-permission generate-tarball.sh 0775 ------------------------------------------------------------- - Please change the encoding of "ChangeLog" file to UTF-8. - All files in srpm must have 0644 permission. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review