Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486558 Paul Lange <palango@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |palango@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |palango@xxxxxx Flag| |fedora-review? --- Comment #1 from Paul Lange <palango@xxxxxx> 2009-02-20 11:05:47 EDT --- This is only an informal review with some things I noticed. Furthermore it's my first review of a non-font package - so expect that I understand some things wrong. * Why do you use ExclusiveArch instead of "ExcludeArch: ppc64"? * %description devel: "contains development and header files...". Does Mono have header files. Maybe something like "The %{name}-devel package contains development files for %{name}." would be more suitable? * Why don't you register the library with gacutil as written in https://fedoraproject.org/wiki/Packaging/Mono#Packaging_Tips ? Is this obsolete? * Maybe include the README file as %doc because it includes some hints on how to use the library and there isn't any other documentation yet. That's all for now :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review