Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: quodlibet - A music management program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202496 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-08-15 21:25 EST ------- Builds fine; here's the rpmlint complaint list: W: quodlibet mixed-use-of-spaces-and-tabs I'm seeing this quite a bit lately. Just do "less -U *spec" and you can see the inconsistencies in indentation. W: quodlibet incoherent-version-in-changelog 0.22-1 0.23-1.fc6 Looks like a typo in your changelog entry. E: quodlibet non-executable-script /usr/share/quodlibet/plugins/songsmenu/replaygain.py 0644 E: quodlibet non-executable-script /usr/share/quodlibet/plugins/songsmenu/_subprocobj.py 0644 I think these are valid. These errors are often false positives, when the python code is actually runnable. But these seem to contain only class definitions, and as such they shouldn't have the shebang line. At least that's my interpretation of things. A while back there was a good IRC discussion about this; I'll try to dig up the log if you'd like to read it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review