Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtirpc https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202224 jkeating@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(steved@xxxxxxxxxx) ------- Additional Comments From jkeating@xxxxxxxxxx 2006-08-15 19:24 EST ------- Whoops, just noticed that buildroot isn't quite right. You have: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n) but the guidelines prefer: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) By using make install DESTDIR=%{buildroot} you no longer have to use --prefix=%{buildroot} as files install in the right place. %{_sysconfdir}/netconfig should probably be marked as a config file, perhaps even config(noreplace). 'netconfig' is a pretty generic term, does anything else use it or are you claiming that namespace? (: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review