Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485636 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-02-19 13:10:35 EDT --- Assigning to myself. Some notes. * SourceURL - I recomment to use %{version} tag in Source because with this you probably won't have to modify SourceURL when the version is upgraded, ref: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D * Description ----------------------------------------------------------- It is free software and distributed under the GNU General Public License Version 2, which can find in the file COPYING. ----------------------------------------------------------- - is not needed because we can check this by "License" tag in the rebuilt rpm. - I also think that ----------------------------------------------------------- It is written using the Qt library by Trolltech. ----------------------------------------------------------- is not needed. * Desktop file issue - From build.log ----------------------------------------------------------- + desktop-file-install --dir /builddir/build/BUILDROOT/cutecom-0.20.0-2.fc11.i386/usr/share/applications/ /builddir/build/BUILD/cutecom-0.20.0/cutecom.desktop /builddir/build/BUILDROOT/cutecom-0.20.0-2.fc11.i386/usr/share/applications/cutecom.desktop: warning: value "" for key "Path" in group "Desktop Entry" does not look like an absolute path ----------------------------------------------------------- I guess Path= item in cutecom.desktop is not needed. - By the way, cutecom.desktop does not have any Categories. Please add the proper one. ? cutecom.desktop specifies "openterm" as Icon, however gnome-icon-theme 2.25.91 does not have openterm.{png,svg} (2.24.x had this icon). Maybe with formal 2.26 gnome-icon-theme release openterm.{png,svg} will reintroduced again, however it may be better that you change Icon item to "utilities-terminal" (actually in gnome-icon-theme 2.24.x, openterm.{png,svg} was symlinks to utilities-terminal.{png,svg}. ? Also please check is the empty line "MimeType=" in cutecom.desktop is needed. If this "MimeType=" line can be removed, then calling "update-desktop-database" on scriptlets is no longer needed, ref: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review