Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478300 --- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-02-18 17:57:56 EDT --- Thanks for the review (In reply to comment #1) > xx - package does not meet Packaging Guidelines and Python Packaging Guidelines > + Is 'Requires: wireless-tools' really needed? I could not locate its use > in the sources, and it seems to work without it too: removed. > xx - License field meets actual license > + Going by the license notices in the source code: > (i) examples/pyiwlist.py is under GPLv2+. > (ii) examples/pyiwconfig.py, pythonwifi/iwlibs.py, pythonwifi/flags.py > is under LGPLv2+. > (iii) the others do not have a license notice. > Although it looks like the value of the License tag should be LGPLv2+ > it would be good to point out the mix-up to the upstream maintainer. changed to LGPLv2+ > xx - sources match upstream sources > + The Source0 URL should be > > http://pypi.python.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz fixed Updated files: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi-0.3.1-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review