Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485973 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jochen@xxxxxxxxxxxxxxx --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-02-18 15:19:58 EDT --- Good: + Base name of SPEC file matches with package name + Download of the upstream tar ball via spectool -g works fine + Packaged tar ball matches with upstream (md5sum: e9ff4a514f08579283e55cfdedff171b) + Package contains License tag with GPLv2+ as an valid OSS license + Package contains verbatin copy of the license tag + Package contains no subpackages + Buildroot definition is ok. + Buildroot will been deleted at the beginning of %clean and %install + Rpmlint silient for source package + Package use parallel build + Local build works fine. + Package honor optflags + Rpmlint is silent for binary package + Rpmlint is silent for debuginfo package + Debuginfo package contains source files * Package create desktop-info file + Local install works fine + Start of the applications works without a crash + Local uninstall works fine + Files permission on the %files stanza are ok. + %file stanza has no duplicated entries + Packaged files are owh by the package + %doc stanza is small, so we need no separate subpackage + %changelog stanza has proper format. Bad: - Please add FDL as an additional license on the license tag - If we remove the automake command, we could remove BR automake, autoconf and libtool - Please start the Menuname with an uppercase. - Build on koji failed (http://koji.fedoraproject.org/koji/taskinfo?taskID=1136545) Question: * Why to you call automake, if you not patch the Makefile.am files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review