Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485607 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: SciTools - |Review Request: scitools - |A Python library for |A Python library for |scientific computing |scientific computing --- Comment #28 from José Matos <jamatos@xxxxxxxx> 2009-02-18 08:37:09 EDT --- I have adjusted the Summary for the new name. One small suggestion, replace Source0: http://scitools.googlecode.com/files/SciTools-0.4.tar.gz with Source0: http://scitools.googlecode.com/files/SciTools-%{version}.tar.gz That avoid to edit that line every time there is a new release. This is a personal preference so you are free to ignore it. Some small nitpicks: * The spec file uses both %{buildroot} and $RPM_BUILD_ROOT, the guidelines warn against using both. Since there is only one instance of $RPM_BUILD_ROOT I suggest to move that to %{buildroot}. * In the website and in %description the capitalization of gnuplot is wrong. Clearly this is really (really) a minor point. I am not sure about the need of an extras sub-package. I would expect that most of the users of this package will have the full set installed. In any case I suggest to move all the dependencies to the main package and only do something about it if there are complains later that this is a problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review