Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485954 --- Comment #3 from Dodji Seketeli <dodji@xxxxxxxxxx> 2009-02-18 05:21:10 EDT --- Hello Joseph, Thanks for the quick review. It's really appreciated. Please find updated spec file, srpm and rpmlint output at: http://people.redhat.com/dseketel/rpms/marlin/marlin.spec-2 http://people.redhat.com/dseketel/rpms/marlin/marlin-0.13-2.fc10.src.rpm http://people.redhat.com/dseketel/rpms/marlin/marlin-0.13-2.rpmlint.txt Koji tasks for the new srpm are: http://koji.fedoraproject.org/koji/taskinfo?taskID=1135111 http://koji.fedoraproject.org/koji/taskinfo?taskID=1135128 > --- Comment #2 from Joseph Smidt <jsmidt@xxxxxxxxxxxxxxxxx> 2009-02-18 [...] > 1. Please be consistant with macros. In some places you use $RPM_BUILD_ROOT, > in others %{buildroot}. Ok, only %{buildroot} is used now. > 2. There is a Requires(pre) but no %pre section. Ooopsy. Added. > 3. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets says scrollkeeper > should look like this: > %post > scrollkeeper-update -q -o %{_datadir}/omf/%{name} || : Done. > %postun > scrollkeeper-update -q || : > Done. > And like this for update-desktop-database: > > %post > update-desktop-database &> /dev/null || : > Done. > %postun > update-desktop-database &> /dev/null || : > Done. > Also, you need to add: > Requires(post): desktop-file-utils > Requires(postun): desktop-file-utils Done. > 4. Remember to post your output for rpmlint. > Done. For the executable warnings, I have filed upstream bug http://bugzilla.gnome.org/show_bug.cgi?id=572255. Thank you for your time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review