Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459444 --- Comment #24 from Sumit Bose <sbose@xxxxxxxxxx> 2009-02-17 17:24:13 EDT --- Thank you for the review. I have addressed: - upstream location/source from git archive issue by adding a description about how to create the tar file from the git repo as describes in the guidelines - changed restart to condrestart - added comments to the patches - use make %{_smp_mflags} I have not - changed the copying of docs, because the makefile already creates a docdir with some files and this seems to conflict with using %doc in the %files section - moved statd-callout, because I think that people who are currently using the upstream version are used to the /etc location, but I will talk to the upstream maintainer about moving it. The new version can be found under http://sbose.fedorapeople.org/ctdb-1.0.71-5.fc10.src.rpm If adas does not mind I can take the ownership for this package, but I would need a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review