Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483620 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dan@xxxxxxxx Flag| |fedora-review? --- Comment #1 from Dan Horák <dan@xxxxxxxx> 2009-02-17 06:00:20 EDT --- formal review is here, see the notes below: OK source files match upstream: 05affb35022128a71d8660b6bcb0b0858a49c330 libbind-6.0b1.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK* compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. BAD rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK shared libraries are added to the regular linker search paths. OK owns the directories it creates. BAD doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in -devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - no need to manually export CFLAGS, the %configure macro takes care of that (rpmbuild --eval %configure) - rpmlint complains a bit libbind-devel.x86_64: W: obsolete-not-provided bind-devel libbind.x86_64: W: obsolete-not-provided bind-libs you should drop the F-7 bits and see https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages for details and/or explain your variant with respect to the guideline libbind.x86_64: W: no-documentation you should include CHANGES, COPYRIGHT and README as %doc libbind.x86_64: W: shared-lib-calls-exit /usr/lib64/libbind.so.4.2.0 exit@xxxxxxxxxxx IMHO can be ignored - you shouldn't own %{_includedir}/{arpa,net,sys} directories (list only the headers) and rather make a dependency on glibc-headers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review