Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453848 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdegoede@xxxxxxxxxx --- Comment #6 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-02-16 07:44:01 EDT --- Not a full review yet but a first round of remarks: MUST FIX: --------- * Add a comment explaining how to get the Source0 tarbal, so people who want to verify its contents against the original can do that * s390x is a 64 bit arch also * since the devel subpackage requires the main package there is no need for it to own directories which are also owned by the main package SHOULD FIX: ----------- * rpmlint warning: globus-core.src: W: mixed-use-of-spaces-and-tabs (spaces: line 116, tab: line 1) * How did you come to the devel / non-devel split. Atleast the aclocal and doxygen files look like devel files to me. Only files which are needed to *run* globus tk using applications should be in the main package, the rest should all be in the devel package * Given the short list of files in the package I see no need for all the magic to generate filelists. Why not just add everything manually (with wildcards) to %files, that way it is much clearer what is going on * Why do you filter out the requires on the gpt modules, the -devel package requiring gpt is fine, and if the main package gets auto requires for gpt that feels like a hint that the package is not split properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review