Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485418 --- Comment #12 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-02-14 14:53:29 EDT --- Few more notes: * No need to install %docs. It's enough to include them in %files, e.g. instead of mkdir -p $RPM_BUILD_ROOT%{_docdir}/vgabios install -m 0644 README COPYING $RPM_BUILD_ROOT%{_docdir}/vgabios ... %files ... %docdir %{_docdir}/vgabios/ %doc %{_docdir}/vgabios/README %doc %{_docdir}/vgabios/COPYING you should write only %files ... %doc README COPYING * Source0 file doesn't match one, shipped within srpm: [petro@Sulaco SOURCES]$ md5sum vgabios-0.6.tgz ~/Desktop/vgabios-0.6b.tgz 35ddf3eaf16abe546797ae9cc18cbd6e vgabios-0.6.tgz 36399621c4d6753e83a3cec3009c7183 /home/petro/Desktop/vgabios-0.6b.tgz [petro@Sulaco SOURCES]$ Generally, it's not a problem if you need to ship different (from upstream) source, but in case then you *really* need to modify upstream sources (or even create tarball from VCS), you *must* provide instructions on how to create exact the same source file in comments to your spec-file. See this spec-file as an example: http://cvs.fedoraproject.org/viewvc/rpms/flashrom/devel/flashrom.spec?view=markup -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review