Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480538 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #20 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-02-13 12:54:06 EDT --- For 0.4.4-2: * License - Although the project URL says this is under GPLv2, judging from the source tarball the license tag should be "GPLv2+" * Version information is specified only in src/iptux.cpp, which is under GPLv2+ * Also src/AboutIptux.cpp shows this is under GPLv2+ (this can be seen by Help->About on iptux) * ref: https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F * BuildRequires - This srpm won't build without "BR: gettext" http://koji.fedoraproject.org/koji/taskinfo?taskID=1125112 * Timestamps - Please consider to use ------------------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------------ to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated from recent autotools. * %{?name} - I guess using %{name} is enough. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review