Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485000 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bugs.michael@xxxxxxx Flag| |fedora-review+ --- Comment #7 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-02-12 07:22:23 EDT --- The new guideline about comments on patches is a "SHOULD" item and not a MUST. Even the SourceForge URLs are not mandatory. No reason to insist on getting them fixed prior to approval. It's not as if the url pointed to the interactive web page. Direct links to a mirror are just fine, since the various wget/curl compatible mirror-selection or round-robin dns urls don't always work for everyone either (and a reviewer ought to visit the upstream site anyway). Additionally, some SF.net projects publish their tarballs with different urls. The guidelines don't cover all cases, as they are more of a hint/recommendation than a strict rule. The redundant %dir didn't cause any files to be mispackaged and didn't cause a build failure either. [...] The packaging is fine: APPROVED [...] Hints and minor issues that can be changed in pkg cvs: * For %setup the "-n %name-%version" parameter is the default. * You mix %_libdir and %_prefix/%_lib in %install section. * Instead of | %dir %{_defaultdocdir}/%{name}-%{version}/ | %{_defaultdocdir}/%{name}-%{version}/LGPL-2.1 | %{_defaultdocdir}/%{name}-%{version}/README you could also use: | %{_defaultdocdir}/%{name}-%{version}/ | %exclude %{_defaultdocdir}/%{name}-%{version}/examples/ Doesn't change much for this package, but could be helpful with other packages where more than two doc files shall be included. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review