Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485186 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-02-12 03:30:29 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1120998 - rpmlint is NOT silent for RPM. perl-MouseX-Types.noarch: W: incoherent-version-in-changelog 0.01-1 ['0.01-0.fc11', '0.01-0'] == >easy to fix at cvs import. + source files match upstream url 8c375c45aa73397c40ac58054d3ca734 MouseX-Types-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=48, 1 wallclock secs ( 0.01 usr 0.02 sys + 0.23 cusr 0.03 csys = 0.29 CPU) + Package perl-MouseX-Types-0.01-0.fc11 => Provides: perl(MouseX::Types) = 0.01 perl(MouseX::Types::Base) perl(MouseX::Types::Mouse) perl(MouseX::Types::TypeDecorator) Requires: perl(Data::Dumper) perl(Mouse::Util::TypeConstraints) perl(MouseX::Types) perl(MouseX::Types::TypeDecorator) perl(Scalar::Util) perl(strict) perl(warnings) Suggestions: 1) Fix Release tag in spec APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review