Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484379 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |palango@xxxxxx Flag| |fedora-review+ --- Comment #1 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-02-11 16:45:18 EDT --- 1. This bit is not strictly necessary # Repeat for every font family -- Sans Mono 2. This one isn't either now that multiple ownership of font dirs was approved; %_font_pkg will now auto-own this dir %dir %{_fontdir} 3. having upstream publish an official sfd version and build from it would be preferred (not a blocker) 4. You need to add a Requires: %{name}-common = %{version}-%{release} to the main package or it won't pull common in (and it's necessary for fontconfig-filesystem) The last one is the only real problem and it's a minor one ✎✎✎ APPROVED ✎✎✎ Please do not forget to fix those little problems, and continue from http://fedoraproject.org/wiki/Font_package_lifecycle#3.a -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review