Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483865 --- Comment #5 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-02-11 16:10:19 EDT --- Ok, some feedback (awesome work BTW) 1. minor: since consensus seems to be that multiple directory ownership is ok in some conditions, %_font_pkg now does it automatically, so you don't need the %dir %{_fontdir} in common anymore (though it's probably harmless). Will need to update the wiki templates to reflect this 2. it does not build in mock, but does build in koji, so your package is probably fine and that's a mock bug (bug #485146) 3. major: the font files declare font family names like "BPG Courier S GPL&GNU". Since fontconfig works with whatever the font files declare, you need to use those names in your fontconfig files in you want them to work (how to pass the & safely is an interesting problem to discuss with Behdad) 4. I'd have used a fontconfig priority of 63-64 to make sure the latin glyphs in those fonts do not override the ones in more mainstream fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review