Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226055 --- Comment #3 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-02-11 12:23:11 EDT --- I've posted a patch upstream[1] which reduces the number of rpmlint problems. Now we are left with: > libvirt.x86_64: E: non-standard-dir-perm /var/lib/libvirt/images 0700 > (for various directories) I think rpmlint is wrong about these errors. The permissions on these directories is intended to be 0700. > libvirt.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/libvirtd Rpmlint's complaint is the logrotate file should have the same name as the package. In this case it has the same name as the daemon, which seems acceptable to me. > libvirt.x86_64: W: dangerous-command-in-%post ln It's a fair warning, but in this case the use of 'ln' in %post is justified. > libvirt-devel.x86_64: W: spurious-executable-perm /usr/share/doc/libvirt-devel-0.6.0/examples/python/domstart.py > (and various other *.py files) For the examples, this seems OK, since people may wish to run the examples directly. For the python libraries, there is a mix of +x/-x permissions, and I don't know what is correct. > libvirt-devel.x86_64: W: doc-file-dependency /usr/share/doc/libvirt-devel-0.6.0/examples/index.py /usr/bin/python > (etc) This seems OK to me. [1] https://www.redhat.com/archives/libvir-list/2009-February/msg00211.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review