[Bug 484486] Review Request: perl-DateTime-Format-Excel - Convert between DateTime and Excel dates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484486


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-02-11 07:56:41 EDT ---
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
- source files match different upstream url
d2f1934833c247b50088fd7999efee04  DateTime-Format-Excel-0.2901.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=3, Tests=77,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.34 cusr  0.02
csys =  0.38 CPU)
+ Package  perl-DateTime-Format-Excel-0.2901-1.fc11->
Provides: perl(DateTime::Format::Excel) = 0.2901
Requires: perl >= 0:5.005 perl(Carp) perl(DateTime) >= 0.1705 perl(strict)
perl(vars)

Suggestion:
1) fix source url to 
http://cpan.perl.org/authors/id/D/DR/DROLSKY/DateTime-Format-Excel-0.2901.tar.gz
 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]