Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478300 --- Comment #1 from Debarshi Ray <debarshi.ray@xxxxxxxxx> 2009-02-11 00:01:47 EDT --- MUST Items: OK - rpmlint is clean OK - follows Naming Guidelines and Python Naming Guidelines OK - spec file is named as %{name}.spec xx - package does not meet Packaging Guidelines and Python Packaging Guidelines + Is 'Requires: wireless-tools' really needed? I could not locate its use in the sources, and it seems to work without it too: [rishi@freebook python-wifi-0.3.1]$ sudo rpm --nodeps -e wireless-tools [sudo] password for rishi: [rishi@freebook python-wifi-0.3.1]$ python Python 2.5.1 (r251:54863, Jun 15 2008, 18:24:56) [GCC 4.3.0 20080428 (Red Hat 4.3.0-8)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from pythonwifi.iwlibs import Wireless >>> wifi = Wireless('wlan0') >>> wifi.getEssid() 'prasannakanan' >>> Am I missing something? OK - license meets Licensing Guidelines xx - License field meets actual license + Going by the license notices in the source code: (i) examples/pyiwlist.py is under GPLv2+. (ii) examples/pyiwconfig.py, pythonwifi/iwlibs.py, pythonwifi/flags.py is under LGPLv2+. (iii) the others do not have a license notice. Although it looks like the value of the License tag should be LGPLv2+ it would be good to point out the mix-up to the upstream maintainer. OK - upstream license file included in %doc OK - spec file uses American English OK - spec file is legible xx - sources match upstream sources + The Source0 URL should be http://pypi.python.org/packages/source/p/%{name}/%{name}-%{version}.tar.gz OK - package builds successfully OK - ExcludeArch not needed OK - build dependencies correctly listed OK - no locales OK - no shared libraries OK - package is not relocatable OK - file and directory ownership OK - no duplicates in %file OK - file permissions set properly OK - %clean present OK - macros used consistently OK - contains code and permissable content OK - -doc is not needed xx - contents of %doc does not affect the runtime + python_wifi.egg-info/SOURCES.txt contains docs/*, examples/* and tests/*. I do not know enough about Python Eggs to say whether that is a problem or not. Got to find out. OK - no header files OK - no static libraries OK - no pkgconfig files OK - no library files OK - -devel not needed OK - no libtool archives OK - %{name}.desktop file not needed OK - does not own files or directories owned by other packages OK - buildroot correctly prepped OK - all file names valid UTF-8 SHOULD Items: OK - upstream provides license text xx - no translations for description and summary OK - package builds in mock successfully OK - package builds on all supported architectures OK - package functions as expected OK - scriptlets not needed OK - subpackages are not needed OK - no pkgconfig files OK - no file dependencies -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review