Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rt2500-(kmod-common) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202529 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-14 18:39 EST ------- BuildRequires: qt-devel >= 3.2.1 If you're only packing this for FC5/6/rawhide, you won't need this. You will need to include desktop-file-utils ExclusiveArch: i686 x86_64 Needs a note explaining why also needs a note why smp_mflags are not used on the make line %install cd Utilitys No. If the file is in Utilitys from the BUILD directory, it should be install Utilitys/foo $RPM_BUILD_DIR%{_bindir}/foo You don't need to use cd mkdir -p $RPM_BUILD_ROOT%{_datadir}/doc/rt2500 install -D -p -m 0644 THANKS CHANGELOG FAQ LICENSE $RPM_BUILD_ROOT%{_datadir}/doc/rt2500 These should be done in the %files section using %doc ie. %doc THANKS CHANGELOG FAQ etc. If the mode is not already correct, %prep is the correct place to fix it. cat > %{name}.desktop <<EOF No Version tag desktop-file-install --vendor livna livna? gtk-update-icon-cache -qf %{_datadir}/pixmaps/rt2500 &>/dev/null || : update-desktop-database &>/dev/null || : Have a look at http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d for advice on this. You can't just assume gtk-update-icon-cache or update-desktop-database exist, they have to be checked and the package they come from included in the BRs %{_datadir}/pixmaps/rt2500/RaConfig2500.xpm %{_datadir}/pixmaps/rt2500/adapter.xpm No. %{_datadir}/pixmaps/%{name}/ is all that is required %doc %{_datadir}/doc/rt2500/* See above -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review