Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484726 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-02-10 13:05:01 EDT --- Good: + Package name fits with naming guidelines + Basename of the SPEC file matches with package name + SPEC file is clearly written. + Consistently usage of rpm macros + Package contains a License tag + Licese tag contains GPLv2+ as a valid OSS license + Package contains verbatin copy of the license text + Could downloading tar ball from upstream with spectool -g + Packaged tar ball matches with upstream (md5sum: 492eda5e3e09beb2f6dc997ed94f5349) + Package contains no patches + Package contains not subpackages + %doc stanza is small, so we need no separate subpackage + Defintion of the BuildRoot is ok. + Buildroot will be cleaned on the beginning of %clean and %install + Local build works fine + Koji build works fine + Package will built for noarch + File permissions seems ok. + Package doesn't contains duplicates files. + All files are own by the package + No file has a conflict to other packages + Local install works fine + Local uninstall works fine + Package contains proper %changelog Bad: - License tag should be GPLv2 because copyright novice of the source doesn't contains late version option - Because the application needs OpenGL enable hardware acceleration a Req. opengl-games-utils is required. Addtionaly a wrapper is required. - DejaVu-Sams-fonts are required for this package - Script contains a reference to pdftk. This package is on review for rpmfusion, because there are licensing issues for the current release. - Its seems, that we will need python-opengl and python-imaging - Please add a %build stanza and a comment which explains, that no special build step is required. - Please add -p switch to the install command in the %install stanza -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review