Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484386 --- Comment #3 from D Haley <mycae@xxxxxxxxx> 2009-02-10 04:06:40 EDT --- SPEC URL: http://dhd.selfip.com/427e/gri-2.spec SRPM URL: http://dhd.selfip.com/427e/gri-2.12.18-2.src.rpm rpmlint output: $ rpmlint ../SRPMS/gri-2.12.18-2.fc10.src.rpm ../RPMS/i386/gri-2.12.18-2.fc10.i386.rpm gri.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1116786 Changelog: * Tue Feb 10 2009 D Haley <mycae@xxxxxxxxx> 2.12.18-2 - Cleared many old changelog entries by D, Kelly & T Powers (year<=2005) - Drop readline buildreq. - Fix lic. GPLv2 to GPLv2+ - Create emacs subpackages - Fix release line to include dist macro >License is GPLv2+, not GPLv2. Done. >Remove Requires: readline, this is automatically picked up. Done. >Remove pushd and popd from setup, you don't need them. Done. >Change make command to make %{?_smp_mflags} as this works fine. The paths are already set by %configure. Done. >Replace "rm -Rf" with "rm -rf" to be consistent. Done. >Absolute paths in %files need to be replaced with %{_bindir}, %{_datadir} and so on. Whoops. Fixed. >Changelog is way too long, IMHO you may remove everything that is before 2006. I removed all but the last entry before myself, just to make it clear that this is based upon someone else's work. >You'll have to branch the emacs script in its own subpackage, as gri probably works without it. Created subpackages emacs-%{name} and emacs-%{name}-el. I am not an emacs user, (brought up on vi(m)) so this is based upon reading refs [1-3]. So there may be a mistake in my understanding here. [1] http://chitlesh.fedorapeople.org/RPMS/dinotrace.spec [2] http://fedoraproject.org/wiki/Packaging/Emacs [3] http://en.wikipedia.org/wiki/Emacs_lisp#Source_code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review