Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484597 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-02-10 03:02:52 EDT --- Nevermind, the package itself uses setuptools and thus the above is not necessary. However, you might be missing one %install line; according to the Python packaging guidelines (PPG) "If your module is using distutils or setuptools, use the following commands during %install: %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT" On the other hand, the package builds the .pyc and .pyo files with the one command you have. Maybe you can enlighten me about the effect of the -O1 switch? Suggestions: - Drop BR on python devel and change BR from python-setuptools to python-setuptools-devel as in PPG. - Change %SOURCE0 line to use %{version} (and maybe %{oname} also?). - Add a line break before %description and delete the one after it to improve legibility. ------------ Package adheres to Packaging Review Guidelines. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review