Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484476 Jeremy Katz <katzj@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |katzj@xxxxxxxxxx --- Comment #1 from Jeremy Katz <katzj@xxxxxxxxxx> 2009-02-09 23:07:24 EDT --- Spec file looks fine; I'm not a huge fan of macro-ifying versions, but that's purely a style question. rpmlint reports telepathy-farsight.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 8) telepathy-farsight-python.x86_64: W: no-documentation The latter of which seems fine, the former should probably be fixed since it's trivial but I trust you'll do that on import The only thing that really pops out at me is that /usr/include/telepathy-1.0 is owned by the telepathy-filesystem package. Maybe just have -devel depend on that instead since it's going to be there for any real telepathy stack usage anyway? Also, have you contacted upstream about killing the rpath? Although it looks like it might just be getting pulled in due to whatever version of autotools they've got rather than anything explicit -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review