Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=480103 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx --- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-02-09 15:41:10 EDT --- > Aren't 'Requires(post): /sbin/ldconfig' and 'Requires(postun): > /sbin/ldconfig' missing? No, they are automatic if /sbin/ldconfig is set as scriptlet processor via option -p. [...] * The entire /usr tree is mispackaged: Package must not include directories /usr/include /usr/lib /usr/lib/debug /usr/share /usr/share/man /usr/share/man/man1 /usr/src /usr/src/debug and no files below /usr/src and /usr/lib/debug either. Where files below /usr/include and /usr/lib are needed (in the -devel subpackage), prefix the paths with %_includedir and %_libdir. Use %_mandir as prefix for files below /usr/share/man * It must not include /usr/lib/debug/ as those files are automatically put into the -debuginfo subpackage. * It must not include /usr/share and not anything in /usr/src either, which is another side-effect of using %_prefix/* as a bad catch-all for all files below /usr * Including static libs as plugins makes no sense. It likely loads the *.so or *.so.0 files. Perhaps the *.la, but not the *.a libs. * The %doc file "INSTALL" is irrelevant to your package users. * The %doc file "NEWS" is empty. You can remove it for now and add a guard in %prep which exists if NEWS is larger than zero. Then you can include it. * rpmlint also reports an executable .spec file. * Including the "config.h" autoheader file in the public API is dangerous. Values in it bear the risk of conflicting with any API-user that uses an own config.h file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review