Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484360 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?, | |needinfo?(michel.sylvan@gma | |il.com) --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> 2009-02-09 09:33:13 EDT --- First some general comments: I've done some vala packages before and they were all named "vala-*" or "*-vala". eg. bug 214227, bug 454668, vala-tools, etc. I suspect we need Vala-specific packaging guidelines in this area. > vscsymbolcompletion.c:63:38: error: vala/valastructvaluetype.h: > No such file or directory We are missing a dependency somehow. vala-devel package does not have this header file. It helps if you could do a Koji scratch build of your package, since that will ensure that all missing BRs have been found. koji build --scratch dist-f11 yourpackage.src.rpm > %setup -q -n vtg-%{version} -n argument not required here (but will be if the package gets a different name ...) > %configure --docdir=%{_datadir}/doc/%{name}-%{version} Is this right? I would have written: --docdir=%{_docdir}/%{name}-%{version} > %doc %{_datadir}/%{name}-%{version} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review