Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456190 --- Comment #28 from Lubomir Rintel <lkundrak@xxxxx> 2009-02-09 08:23:17 EDT --- Good work, I'm sure the reviewer will be much more happy about the package now :o) (In reply to comment #26) > no, this is the first RPM so it would make no sense why I need to update the > changelog at this point, all I have done is corrected the spec file to try and > get it released in the first place. Well, reviewers like to compare to the previous version of the package they were reviewing, and bumping Release and adding %changelog makes them happy :) > > * Categories=System;Emulator; > > > > The Categories in the desktop file should be changed to "Game;Emulator;". This > > is what other emulators use. > > > I didnt want this to be a game category because its not just a game emulator, > its a dos emulator, but I have changed it anyways. Please revert back, this is a violation of the Desktop Menu Specification. I'm sure this is minor enough not to bother you (see comment #24). > > - RPM_OPT_FLAGS are not used. > > > I dont know of any opt flags needed, I remember going over all this stuff, and > its not because I just dont know anything, Please have a look at the guidelines: https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags Just in case you missed anything else there, please make sure that you're familiar with the whole guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review