Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484229 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx --- Comment #12 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-02-07 17:16:48 EDT --- * Source0 points to a web page. The following Source0 location actually points to a wget/curl-downloadable tarball: http://downloads.sf.net/qbittorrent/qbittorrent-1.3.0.tar.gz > ./configure --prefix=$RPM_BUILD_ROOT%{_prefix} This --prefix is wrong. That's too much risk that the buildroot path finds its way into compiled/built files. Use --prefix=%{_prefix} only. > gmake %{?_smp_mflags} "gmake" is a softlink to "make", why not just use "make" from package "make" then? ;) > %doc README INSTALL NEWS COPYING AUTHORS TODO Changelog File "INSTALL" is irrelevant to the package users. * Run "rpmlint" on your src.rpm and built rpms and apply fixes as appropriate: $ rpmlint qbittorrent-1.3.0-4.fc10.src.rpm qbittorrent.src:27: W: configure-without-libdir-spec qbittorrent.src:29: W: rpm-buildroot-usage %build ./configure --prefix=$RPM_BUILD_ROOT%{_prefix} qbittorrent.src:29: W: configure-without-libdir-spec qbittorrent.src: E: description-line-too-long A Bittorrent client using C++ / rb_libtorrent and a Qt4 Graphical User Interface. 1 packages and 0 specfiles checked; 1 errors, 3 warnings. * The Warning about missing --libdir usage can be ignored. * Testbuild will need Rawhide (F11 devel): Checking for libtorrent-rasterbar >= 0.14 ... no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review