[Bug 480859] Review Request: diffuse - graphical diff tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480859


Michael Schwendt <bugs.michael@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bugs.michael@xxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |bugs.michael@xxxxxxx
               Flag|                            |fedora-review?




--- Comment #9 from Michael Schwendt <bugs.michael@xxxxxxx>  2009-02-07 16:43:13 EDT ---
> you're missing somethint in changelog

No. The first %changelog entry quoted in comment 4 is fine.


> macronify more.

No. The request in comment 5 leads to macro-madness. Only in some cases it is
convenient to replace the program name with %{name} -- e.g. if you want to
reuse a spec file for other packages. It doesn't happen often that a program
changes its name frequently, so that using %name everywhere (even in URL and
%files lists) would be justified.


* The guidelines want the .desktop file to be validated in the %install
section:
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage


* The guidelines include specific shell code for scrollkeeper-update and
desktop-data-base usage:

https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scrollkeeper
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database


* Several directories are not included in %files:

  %dir %{_datadir}/gnome/help/diffuse
  %dir %{_datadir}/gnome/help/diffuse/C
  %dir %{_datadir}/omf/diffuse

https://fedoraproject.org/wiki/Packaging/UnownedDirectories


* Rest is good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]