Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474430 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-02-07 02:35:58 EDT --- Unfortunately your comment came after the start of the semester, so I've been a bit busy. Fortunately I have more time now, so I can finish this up. Things look good now that this is noarch. The only remaining issue I see is that you have Requires: python >= 2.3, python < 2.5 However, rpm will automaticaly insert a dependency on python(abi) = 2.4 Currently there's no guideline against this, but you might want to check out the following draft, which is working its way through the system: http://fedoraproject.org/wiki/PackagingDrafts/ExplicitRequires So I'll go ahead and approve this, but I would recommend that you kill that extra Requires: line. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review